[gcc r13-9711] libstdc++: Implement P2540R1 change to views::cartesian_product()
Patrick Palka
ppalka@gcc.gnu.org
Tue May 27 20:31:05 GMT 2025
https://gcc.gnu.org/g:d28b05bf576d4b5ebeda2a44430d2cb17e1fa027
commit r13-9711-gd28b05bf576d4b5ebeda2a44430d2cb17e1fa027
Author: Patrick Palka <ppalka@redhat.com>
Date: Tue Jan 16 21:20:12 2024 -0500
libstdc++: Implement P2540R1 change to views::cartesian_product()
This paper changes the identity element of views::cartesian_product to a
singleton range instead of an empty range. It was approved alongside
the main cartesian_product paper P2374R4, but unfortunately was overlooked
when implementing the main paper.
libstdc++-v3/ChangeLog:
* include/std/ranges (views::_CartesianProduct::operator()):
Adjust identity case as per P2540R1.
* testsuite/std/ranges/cartesian_product/1.cc (test01):
Adjust expected result of the identity case.
Reviewed-by: Jonathan Wakely <jwakely@redhat.com>
(cherry picked from commit 98966f32f906303cd7d2e1c418f320c483e6dcbe)
Diff:
---
libstdc++-v3/include/std/ranges | 2 +-
libstdc++-v3/testsuite/std/ranges/cartesian_product/1.cc | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/libstdc++-v3/include/std/ranges b/libstdc++-v3/include/std/ranges
index daf3f32b808c..dda61349c8fd 100644
--- a/libstdc++-v3/include/std/ranges
+++ b/libstdc++-v3/include/std/ranges
@@ -8549,7 +8549,7 @@ namespace views::__adaptor
operator() [[nodiscard]] (_Ts&&... __ts) const
{
if constexpr (sizeof...(_Ts) == 0)
- return views::empty<tuple<>>;
+ return views::single(tuple{});
else
return cartesian_product_view<all_t<_Ts>...>(std::forward<_Ts>(__ts)...);
}
diff --git a/libstdc++-v3/testsuite/std/ranges/cartesian_product/1.cc b/libstdc++-v3/testsuite/std/ranges/cartesian_product/1.cc
index ef2ece4a1686..a44465fc7e55 100644
--- a/libstdc++-v3/testsuite/std/ranges/cartesian_product/1.cc
+++ b/libstdc++-v3/testsuite/std/ranges/cartesian_product/1.cc
@@ -23,9 +23,9 @@ test01()
int w[] = {9};
auto v0 = views::cartesian_product();
- VERIFY( ranges::end(v0) - ranges::begin(v0) == 0 );
- VERIFY( ranges::size(v0) == 0 );
- VERIFY( ranges::empty(v0) );
+ VERIFY( ranges::end(v0) - ranges::begin(v0) == 1 );
+ VERIFY( ranges::size(v0) == 1 );
+ VERIFY( !ranges::empty(v0) );
auto v1 = views::cartesian_product(x);
VERIFY( ranges::end(v1) - ranges::begin(v1) == 3 );
More information about the Libstdc++-cvs
mailing list