[gcc/devel/omp/gcc-14] libstdc++: Avoid '-Wunused-parameter' for 'is_directory' in member function 'bool std::filesystem::_

Thomas Schwinge tschwinge@gcc.gnu.org
Wed Mar 19 09:09:26 GMT 2025


https://gcc.gnu.org/g:5467cb56ee7b9c77ead72da6470456595531f0d8

commit 5467cb56ee7b9c77ead72da6470456595531f0d8
Author: Thomas Schwinge <tschwinge@baylibre.com>
Date:   Wed Feb 19 20:18:52 2025 +0100

    libstdc++: Avoid '-Wunused-parameter' for 'is_directory' in member function 'bool std::filesystem::__cxx11::_Dir::do_unlink(bool, std::error_code&) const'
    
    In a newlib configuration:
    
        ../../../../../source-gcc/libstdc++-v3/src/c++17/fs_dir.cc: In member function ‘bool std::filesystem::__cxx11::_Dir::do_unlink(bool, std::error_code&) const’:
        ../../../../../source-gcc/libstdc++-v3/src/c++17/fs_dir.cc:147:18: error: unused parameter ‘is_directory’ [-Werror=unused-parameter]
          147 |   do_unlink(bool is_directory, error_code& ec) const noexcept
              |             ~~~~~^~~~~~~~~~~~
    
            libstdc++-v3/
            * src/c++17/fs_dir.cc (do_unlink): Tag 'is_directory' as
            '[[maybe_unused]]'.
    
    (cherry picked from commit b122afef2a584d15dbc594074bbe444c4fa74cb7)

Diff:
---
 libstdc++-v3/ChangeLog.omp       | 6 ++++++
 libstdc++-v3/src/c++17/fs_dir.cc | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/libstdc++-v3/ChangeLog.omp b/libstdc++-v3/ChangeLog.omp
index 447d3c11ddbc..a3487cda9291 100644
--- a/libstdc++-v3/ChangeLog.omp
+++ b/libstdc++-v3/ChangeLog.omp
@@ -3,6 +3,12 @@
 	Backported from trunk:
 	2025-03-06  Thomas Schwinge  <tschwinge@baylibre.com>
 
+	* src/c++17/fs_dir.cc (do_unlink): Tag 'is_directory' as
+	'[[maybe_unused]]'.
+
+	Backported from trunk:
+	2025-03-06  Thomas Schwinge  <tschwinge@baylibre.com>
+
 	* src/filesystem/dir-common.h (openat): Tag 'nofollow' as
 	'[[maybe_unused]]'.
 
diff --git a/libstdc++-v3/src/c++17/fs_dir.cc b/libstdc++-v3/src/c++17/fs_dir.cc
index fa0f7281f369..9fbd1b71f062 100644
--- a/libstdc++-v3/src/c++17/fs_dir.cc
+++ b/libstdc++-v3/src/c++17/fs_dir.cc
@@ -144,7 +144,7 @@ struct fs::_Dir : _Dir_base
   }
 
   bool
-  do_unlink(bool is_directory, error_code& ec) const noexcept
+  do_unlink([[maybe_unused]] bool is_directory, error_code& ec) const noexcept
   {
 #if _GLIBCXX_HAVE_UNLINKAT
     const auto atp = current();


More information about the Libstdc++-cvs mailing list