[PATCH 6/6] Add test of input file flushing / offset issues

DJ Delorie dj@redhat.com
Tue Jan 21 02:30:41 GMT 2025


Joseph Myers <josmyers@redhat.com> writes:
> On Wed, 15 Jan 2025, DJ Delorie wrote:
>> Should include one pseudo-random location (mid-buffer), and one near the
>> end (i.e. read to EOF then ungetc).
>
> Added offsets BUFSIZ / 2 and 2 * BUFSIZ.
>
>> I see we add an offset of 0..3 in the main loop, but that doesn't insert
>> tests *before* block breaks, just *after* them.
>
> Changed to cover offsets -2 to 3.

LGTM
Reviewed-by: DJ Delorie <dj@redhat.com>



More information about the Libc-alpha mailing list