[PATCH v7 08/23] aarch64: Add GCS support for makecontext

[Yury Khrustalev]

Hi Adhemerval

On Tue, Jan 07, 2025 at 02:12:31PM -0300, Adhemerval Zanella Netto wrote:
> 
> > +#ifndef __NR_map_shadow_stack
> > +# define __NR_map_shadow_stack 453
> > +#endif
> 
> It is already define at sysdeps/unix/sysv/linux/aarch64/arch-syscall.h.
>

Fair point. I will remove this bit.

> > +#ifndef SHADOW_STACK_SET_TOKEN
> > +# define SHADOW_STACK_SET_TOKEN (1UL << 0)
> > +# define SHADOW_STACK_SET_MARKER (1UL << 1)
> 
> Maybe add this on bits/mmap.h, as x86 does for SHADOW_STACK_SET_TOKEN.

The idea here is to define these constants locally rather than in
any of the public headers. Once Linux kernel is released there will
be another patch to declare some of these constants in the public
headers, but this will likely be after the upcoming Glibc release.

I will leave this unchanged.

Thanks,
Yury