[PATCH v15 0/8] Add rseq extensible ABI support

[Andreas K. Huettel]

Am Mittwoch, 8. Januar 2025, 12:05:05 Mitteleuropäische Normalzeit schrieb Florian Weimer:
> * Michael Jeanson:
> 
> > Introduced in Linux v6.3 the rseq extensible ABI [1] will allow adding
> > rseq features past the initial 32 bytes of the original ABI.
> 
> I've completed my review.  I think we are getting really close.
> 
> Andreas, do you think we can still merge this for glibc 2.41?  Ideally I
> would give this some soak time in Fedora rawhide, maybe a week or two.

I'm fine with this still going in, it's been planned long enough. 
Including the required TLS_TP_OFFSET series.

> So if you want to release next Monday, merging this later this the week
> would not be a good idea.

Mostly for this exact reason (finishing up and committing long-reviewed patch
series) we still have time for testing. See also pthread condvar and GCS.

I'd like to do the release before I leave on 30/Jan for FOSDEM.
Otherwise I'm flexible about the date (and never thought about as early as
next monday; that would be 13/Jan).

Best,
Andreas

> 
> The pointer/size arithmetic looks in the extra TLS setup looks correct
> to me (except for two nits, one of them not relevant to Linux).  But
> incorrect TLS allocation overlap does not always lead to immediate
> issues.  And the other problem is that we do not have a kernel that
> truly exercises the extension bits (as seen by the open question of the
> relationship between the size/alignment values).
> 
> If we want to merge this, we also need the TLS_TP_OFFSET series:
> 
>   [PATCH v2 0/3] Define TLS_TP_OFFSET on all architectures
>   <https://inbox.sourceware.org/libc-alpha/cover.1736275068.git.fweimer@redhat.com/>
> 
> Thanks,
> Florian
> 
> 


-- 
Andreas K. Hüttel
dilfridge@gentoo.org
Gentoo Linux developer
(council, toolchain, base-system, perl, libreoffice)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 981 bytes
Desc: This is a digitally signed message part.
URL: <https://sourceware.org/pipermail/libc-alpha/attachments/20250108/417f1eec/attachment.sig>