[PATCH 09/59] Omit parse_offset unnecessary *tz == '\0'

Paul Eggert eggert@cs.ucla.edu
Sun Jan 5 05:56:44 GMT 2025


* time/tzset.c (parse_offset): Simplify by omitting unnecessary
(*tz == '\0') test.
---
 time/tzset.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/time/tzset.c b/time/tzset.c
index a0bf3382ba..9fb3a127f7 100644
--- a/time/tzset.c
+++ b/time/tzset.c
@@ -189,12 +189,13 @@ static bool
 parse_offset (const char **tzp, int whichrule)
 {
   const char *tz = *tzp;
+  bool leading_sign = *tz == '-' || *tz == '+';
   if (whichrule == 0
-      && (*tz == '\0' || (*tz != '+' && *tz != '-' && !isdigit (*tz))))
+      && (!leading_sign && !isdigit (*tz)))
     return false;
 
   int sign;
-  if (*tz == '-' || *tz == '+')
+  if (leading_sign)
     sign = *tz++ == '-' ? 1 : -1;
   else
     sign = -1;
-- 
2.45.2



More information about the Libc-alpha mailing list