[PATCH 2/2] loongarch: Drop __GI_XXX for strcpy/stpcpy IFUNC implementations

Sam James sam@gentoo.org
Sat Jan 4 15:31:03 GMT 2025


"H.J. Lu" <hjl.tools@gmail.com> writes:

> There is no need for __GI_XXX symbols, like __GI___strcpy_aligned since
> __strcpy_aligned is used directly.
>
> Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
> ---

Reviewed-by: Sam James <sam@gentoo.org>

I CC'd loong maints in case but I think it's straightforward (and a nice catch).

>  sysdeps/loongarch/lp64/multiarch/strcpy-aligned.S   | 2 --
>  sysdeps/loongarch/lp64/multiarch/strcpy-lasx.S      | 1 -
>  sysdeps/loongarch/lp64/multiarch/strcpy-lsx.S       | 1 -
>  sysdeps/loongarch/lp64/multiarch/strcpy-unaligned.S | 1 -
>  4 files changed, 5 deletions(-)
>
> diff --git a/sysdeps/loongarch/lp64/multiarch/strcpy-aligned.S b/sysdeps/loongarch/lp64/multiarch/strcpy-aligned.S
> index 6bf0b803f1..43d74f611b 100644
> --- a/sysdeps/loongarch/lp64/multiarch/strcpy-aligned.S
> +++ b/sysdeps/loongarch/lp64/multiarch/strcpy-aligned.S
> @@ -198,5 +198,3 @@ L(un_out):
>  #endif
>      jr          ra
>  END(STRCPY)
> -
> -libc_hidden_builtin_def (STRCPY)
> diff --git a/sysdeps/loongarch/lp64/multiarch/strcpy-lasx.S b/sysdeps/loongarch/lp64/multiarch/strcpy-lasx.S
> index 02c8dc6d7a..5629283208 100644
> --- a/sysdeps/loongarch/lp64/multiarch/strcpy-lasx.S
> +++ b/sysdeps/loongarch/lp64/multiarch/strcpy-lasx.S
> @@ -211,5 +211,4 @@ L(zero_byte):
>      jr              ra
>  END(STRCPY)
>  
> -libc_hidden_builtin_def (STRCPY)
>  #endif
> diff --git a/sysdeps/loongarch/lp64/multiarch/strcpy-lsx.S b/sysdeps/loongarch/lp64/multiarch/strcpy-lsx.S
> index 906bd2feea..97a612b960 100644
> --- a/sysdeps/loongarch/lp64/multiarch/strcpy-lsx.S
> +++ b/sysdeps/loongarch/lp64/multiarch/strcpy-lsx.S
> @@ -208,5 +208,4 @@ L(INDEX):
>      .dword          0x0706050403020100
>      .dword          0x0f0e0d0c0b0a0908
>  
> -libc_hidden_builtin_def (STRCPY)
>  #endif
> diff --git a/sysdeps/loongarch/lp64/multiarch/strcpy-unaligned.S b/sysdeps/loongarch/lp64/multiarch/strcpy-unaligned.S
> index f6a29796ad..7231b4d792 100644
> --- a/sysdeps/loongarch/lp64/multiarch/strcpy-unaligned.S
> +++ b/sysdeps/loongarch/lp64/multiarch/strcpy-unaligned.S
> @@ -134,5 +134,4 @@ L(page_cross):
>      b           L(end)
>  END(STRCPY)
>  
> -libc_hidden_builtin_def (STRCPY)
>  #endif


More information about the Libc-alpha mailing list