[PATCH v2] math: Remove no-mathvec flag
Wilco Dijkstra
Wilco.Dijkstra@arm.com
Fri Jan 3 21:34:40 GMT 2025
Hi Joe,
> More routines are to follow, some of which hit many failures in the
> current testsuite due to wrong sign of zero (mathvec routines are not
> required to get this right). Instead of disabling a large number of
> tests, change the failure condition such that, for vector routines,
> tests pass as long as computed == expected == 0.0, regardless of sign.
>
> Affected tests (vector tests for expm1, log1p, sin, tan and tanh) all
> still pass.
> ---
> Changes from v1:
> * Fold flag-no-mathvec into the existing mechanism for skipping sign
> of zero. IGNORE_ZERO_INF_SIGN is applied at the routine level, so I
> can't see any way of using this flag without also ignoring sign of
> zero for scalar routines
The new version is better and similar to the way we already handle
ignoring exceptions for vector functions. Maybe in the future we can make
it more general.
> The 3 patches with new trig routines apply OK and pass tests when
> applied on top of this. Is this OK, or do I need to rebase and
> send them again?
No that's fine, I only needed to fixup the ULPs for tanpif due to Paul's
recent new inputs.
OK, committed.
Cheers,
Wilco
More information about the Libc-alpha
mailing list