[SUMMARY] Re: [PATCH v2 0/1] libgccjit: Make is_same_type_as() supporting floating point types

[Antoni Boucher via Sourceware Forge]

This is a summary of discussions relative to the merge request created by Antoni Boucher (antoyo) titled
libgccjit: Make is_same_type_as() supporting floating point types
since its creation.

Description: ```
gcc/jit/ChangeLog:

	* jit-recording.h: Fix float comparison.
	* libgccjit.cc: Fix type check in gcc_jit_context_new_comparison.

gcc/testsuite/ChangeLog:

	* jit.dg/all-non-failing-tests.h: Mention new test.
	* jit.dg/test-comparison.c: New test.

Co-authored-by: Antoni Boucher <bouanto@zoho.com>
```

CC: David Malcolm <dmalcolm@redhat.com>, <jit@gcc.gnu.org>

The full and up to date discussion can be found at https://forge.sourceware.org/gcc/gcc-TEST/pulls/97

The merge request has been closed without being merged directly on the forge repository.

On 2025-10-15 12:57:08+00:00, Antoni Boucher (antoyo) commented on the code:


> +++ gcc/testsuite/jit.dg/test-comparison.c
> @@ -0,0 +29,4 @@
> +  gcc_jit_target_info* target_info = gcc_jit_context_get_target_info (ctxt);
> +  if (gcc_jit_target_info_supports_target_dependent_type (target_info,
> +							  GCC_JIT_TYPE_FLOAT32))
> +    float32_type = gcc_jit_type_get_aligned (float_type, 4);
When the dependent PR is merged, use `GCC_JIT_TYPE_FLOAT32` here.

On 2026-05-22 14:54:05+00:00, David Malcolm (dmalcolm) <dmalcolm@gcc.gnu.org> approved the changes:
I'd reword the title to "libgccjit: Make is_same_type_as() support floating point types"

Other than that, LGTM; thanks.



On 2026-06-17 14:31:38+00:00, Antoni Boucher (antoyo) wrote:

Thanks for the review.
Merged.