[SUMMARY] Re: [PATCH v1 0/1] libgccjit: Handle missing types in jit_langhook_type_for_mode
Antoni Boucher via Sourceware Forge
forge-bot+antoyo@forge-stage.sourceware.org
Wed Jun 17 14:12:09 GMT 2026
This is a summary of discussions relative to the merge request created by Antoni Boucher (antoyo) titled
libgccjit: Handle missing types in jit_langhook_type_for_mode
since its creation.
Description: ```
gcc/jit/ChangeLog:
* dummy-frontend.cc: Handle new types in jit_langhook_type_for_mode.
```
On some targets (I found this was the case for Aarch64, probably), we need to handle some float types in jit_langhook_type_for_mode.
CC: David Malcolm <dmalcolm@redhat.com>, <jit@gcc.gnu.org>
The full and up to date discussion can be found at https://forge.sourceware.org/gcc/gcc-TEST/pulls/87
The merge request has been closed without being merged directly on the forge repository.
On 2025-09-29 18:29:50+00:00, Antoni Boucher (antoyo) wrote:
I'm not sure how I could test this since this is not needed on x86-64. Any ideas?
On 2025-09-29 18:57:17+00:00, Antoni Boucher (antoyo) wrote:
@rdfm: It seems the bot will send the email for the patch with the send date being the date on the patch.
Is this expected? This could make the email harder to find in mail clients that sort by date.
On 2025-10-01 15:37:18+00:00, Claudio Bantaloukas (rdfm) wrote:
@antoyo indeed, the code in batrachomyomachia will [run git format-patch](https://forge.sourceware.org/forge/batrachomyomachia/src/commit/f5fac826475293deabceb5f4d0b7b1eba88530cb/batrachomyomachia/local_git_ops.py#L549) and then [send the generated emails](https://forge.sourceware.org/forge/batrachomyomachia/src/commit/f5fac826475293deabceb5f4d0b7b1eba88530cb/batrachomyomachia/email.py#L81) without further changes to the Date.
My perl is rusty but I think what happens with git send-email is [that patch emails lose the date generated by git format-patch](https://github.com/git/git/blob/821f583da6d30a84249f75f33501504d597bc16b/git-send-email.perl#L1571).
I should add a ticket to sort this out.
On 2026-05-22 14:57:34+00:00, David Malcolm (dmalcolm) <dmalcolm@gcc.gnu.org> approved the changes:
Thanks; LGTM
On 2026-06-17 14:11:58+00:00, Antoni Boucher (antoyo) wrote:
Thanks for the review.
Merged.
More information about the Jit
mailing list