[PATCH v2 0/1] libgccjit: Add support for Aarch64 CPU features

[Drea Pinski via Sourceware Forge]

Drea Pinski (pinskia) <pinskia@gcc.gnu.org>) commented on the code:


> +++ gcc/config/aarch64/aarch64-jit.cc
> @@ -0,0 +123,4 @@
> +    jit_add_target_info ("target_feature", "tme");
> +  // TODO: features dit, dpb, dpb2, flagm, lor, pan, pmuv3, ras, spe, ssbs, vh
> +
> +  if (AARCH64_HAVE_ISA (V8_1A))
as this part:
```
#define AARCH64_ARCH(NAME, CORE, ARCH_IDENT, ARCH_REV, FLAGS) \
if (AARCH64_HAVE_ISA (ARCH_IDENT)) jit_add_target_info ("target_feature", NAME);
#include "aarch64-arches.def"
```
I Noticed you didn't include v9 here either which seems wrong. and v8.8/v8.9 are also missing :)
This is why duplicating things is the wrong approach.


--
https://forge.sourceware.org/gcc/gcc-TEST/pulls/108#issuecomment-3091