[PATCH v1 0/1] libgccjit: Add a function to check if LTO is supported

[Antoni Boucher via Sourceware Forge]

Antoni Boucher (antoyo)) commented on the code:


> +++ gcc/jit/Make-lang.in
> @@ -130,6 +130,10 @@ jit.serial = $(LIBGCCJIT_FILENAME)
>  # Tell GNU make to ignore these if they exist.
>  .PHONY: jit
>  
> +CFLAGS-jit/libgccjit.o += -DDEFAULT_TARGET_VERSION=\"$(version)\" \
This is a `.in` file, but I was unable to regenerate the file.
Am I doing something wrong or do the `Make-lang.in` files need not being regenerated?

> +++ gcc/jit/Make-lang.in
> @@ -130,6 +130,10 @@ jit.serial = $(LIBGCCJIT_FILENAME)
>  # Tell GNU make to ignore these if they exist.
>  .PHONY: jit
>  
> +CFLAGS-jit/libgccjit.o += -DDEFAULT_TARGET_VERSION=\"$(version)\" \
I don't think you need to regenerate anything after changing them indeed. You can verify it by running the `autoregen.py` script from https://sourceware.org/cgit/builder.


--
https://forge.sourceware.org/gcc/gcc-TEST/pulls/103#issuecomment-2967