[PATCH] libgccjit: Handle truncation and extension for casts [PR 95498]

David Malcolm dmalcolm@redhat.com
Thu Jul 8 21:34:42 GMT 2021


On Thu, 2021-07-08 at 17:28 -0400, Antoni Boucher wrote:
> Is this the approval for write or are we not there yet?

Assuming it passes the regression tests, yes - approved for trunk.

Dave

> 
> Le jeudi 08 juillet 2021 à 16:44 -0400, David Malcolm a écrit :
> > On Tue, 2021-07-06 at 09:00 -0400, Antoni Boucher wrote:
> > > I updated the patch to fix this.
> > > I'm sending the patch once again for review.
> > > Thanks.
> > 
> > Looks good to me.
> > 
> > Dave
> > 
> > > 
> > > Le samedi 19 juin 2021 à 11:08 +0200, Bernhard Reutner-Fischer a
> > > écrit :
> > > > On 18 June 2021 23:11:58 CEST, Antoni Boucher via Gcc-patches
> > > > <gcc-patches@gcc.gnu.org> wrote:
> > > > > Ok.
> > > > > Here's the patch with the updated subject and with format
> > > > > fixed.
> > > > 
> > > > +  if (t_ret)
> > > > +      return t_ret;
> > > > +  enum tree_code dst_code = TREE_CODE (dst_type);
> > > > +  switch (dst_code)
> > > > +    {
> > > > 
> > > > The enum is redundant.
> > > > /enum tree_code/s/enum //
> > > > thanks,
> > > 
> > 
> > 
> 
> 




More information about the Jit mailing list