[PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_binary_op

[David Malcolm]

On Mon, 2019-06-24 at 15:30 +0000, Andrea Corallo wrote:
> Hi all,
> second version for this patch.
> Given the suggestion for the bit-field one I've tried to improve also
> here the error message.

Thanks.

> I've added a simple testcase as requested, here I'm trying to do
> *void=int+int.
> This without checking would normally crash verifying gimple.

Thanks.  FWIW, I think the testcase can be simplified slightly, in that
all that's needed is a bogus call to gcc_jit_context_new_binary_op, so
I don't think the testcase needs the calls to:
  gcc_jit_context_new_function,
  gcc_jit_function_new_block, and
  gcc_jit_block_end_with_return,
it just needs the types and the gcc_jit_context_new_binary_op call.

> More complex cases can be cause of crashes having the
> result type structures etc...
> 
> Tested with make check-jit
> OK for trunk?

Looks good as-is, or you may prefer to simplify the testcase.

Thanks for the patch.

BTW, I don't see you listed in the MAINTAINERS file; are you able to
commit patches yourself?

Dave

> Bests
>   Andrea
> 
> 2019-06-09  Andrea Corallo  andrea.corallo@arm.com
> 
> * libgccjit.c (gcc_jit_context_new_binary_op): Check result_type to
> be a
> numeric type.
> 
> 
> 2019-06-20  Andrea Corallo andrea.corallo@arm.com
> 
> * jit.dg/test-error-gcc_jit_context_new_binary_op-bad-res-type.c:
> New testcase.