about header file parsing

David Malcolm dmalcolm@redhat.com
Tue Jan 1 00:00:00 GMT 2019


On Thu, 2019-01-10 at 19:06 +0000, akrl wrote:

[...]

> Hi,
> today I've wrote a patch that adds GCC_JIT_STR_NEEDED_LIBRARIES to
> gcc_jit_str_option.
> This was to specify a space separated list of the libraries to link
> against.
> I was going to submit the patch for review but this solution seams to
> be
> more general.

FWIW, although it sounds like it's no longer relevant here, I prefer to
avoid extending the
  enum gcc_jit_str_option
and
  enum gcc_jit_int_option
enumerations, in favor of adding new API entrypoints, for the ABI-
detection reason given here:
https://gcc.gnu.org/onlinedocs/jit/topics/contexts.html#options

i.e. "Adding entrypoints for each new option means that client code
that use the new options can be identified directly from binary
metadata, which would not be possible if we instead extended the
various enum gcc_jit_*_option."

> If we agree on an interface I propose my self to do the patch in
> order
> to have the occasion to setup the whole process.
> 
> Bests
> 
>   Andrea

It's great to have new contributors to the project.

Andrea: FWIW, the FSF requires some legal paperwork before I can accept
non-trivial patches; see:
  https://gcc.gnu.org/contribute.html#legal
If you're hoping to send non-trivial patches, it might be an idea to
look into that (unless you already have the FSF paperwork in place?)

Thanks
Dave



More information about the Jit mailing list