PATCH trunk GCCJIT: adding gcc_jit_context_new_rvalue_from_long_long, etc...

[David Malcolm]

On Wed, 2015-07-15 at 21:15 +0200, Basile Starynkevitch wrote:
> On 07/15/2015 20:52, David Malcolm wrote:
> > On Wed, 2015-07-15 at 20:19 +0200, Basile Starynkevitch wrote:
> >> Hello All and David Malcolm
> >>
> >> The attached patch (relative to trunk r224842) is adding
> >> gcc_jit_context_new_rvalue_from_long_long and similar functions to
> >> GCCJIT.
> > Does this actually link and run? This appears to be missing some 
> > implementations of the template specializations in jit/jit-recording.c 
> > for the new specializations of new_rvalue_from_const. If these are 
> > missing, I'd expect to see a linker error at run-time when attempting 
> > to run client code that links against such a libgccjit.so. 
> 
> It does bootstrap (in the GCC sense). I suspect that C++ integral 
> promotion or casting rules are enough to have something being linked, 
> but probably not what is really needed. 

Perhaps, but note that nothing in a regular gcc bootstrap uses
libgccjit, so you *might* still have a latent linking error that shows
up only at run time.   Running the jit testsuite is the best way to be
sure.

> And I'm testing that on 
> x86-64/Linux where the patch is almost useless.
> 
> Thanks for your other comments. I'm trying to understand them and I am 
> working on that.
> 
> Cheers
>