[PATCH 13/27] New file: gcc/jit/jit-recording.c

[Jeff Law]

On 10/31/14 11:02, David Malcolm wrote:
> Implementation of the gcc::jit::recording internal API, so that
> libgccjit.c can record the calls that are made to the public API, for
> later playback by the dummy frontend.
>
> gcc/jit/
> 	* jit-recording.c: New.
Cursory review since it's the JIT implementation directory which you'll 
likely end up owning...


> +
> +/* Assuming that this block has been terminated, get the number of
> +   successor blocks, which will be 0, 1 or 2, for return, unconditional
> +   jump, and conditional jump respectively.
> +   NEXT1 and NEXT2 must be non-NULL.  The first successor block (if any)
> +   is written to NEXT1, and the second (if any) to NEXT2.
> +
> +   Used when validating functions, and when dumping dot representations
> +   of them.  */
So presumably no multi-way branches yet?  Might be better to build the 
API in such a way that it handles multi-way branches from the get-go 
rather than retrofitting later.  Your call.

Otherwise I don't see anything objectionable.  OK for the trunk.
jeff