[PATCH 12/27] New file: gcc/jit/jit-recording.h

Jeff Law law@redhat.com
Wed Jan 1 00:00:00 GMT 2014


On 10/31/14 11:02, David Malcolm wrote:
> This file declares the gcc::jit::recording internal API, so that
> libgccjit.c can record the calls that are made to the public API, for
> later playback by the dummy frontend.
>
> gcc/jit/
> 	* jit-recording.h: New.
> ---
>   gcc/jit/jit-recording.h | 1593 +++++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 1593 insertions(+)
>   create mode 100644 gcc/jit/jit-recording.h
>
> diff --git a/gcc/jit/jit-recording.h b/gcc/jit/jit-recording.h
> new file mode 100644
> index 0000000..bb1a2ee
> --- /dev/null
> +++ b/gcc/jit/jit-recording.h
[ ... ]

> +
> +private:
> +  void validate ();
So give the complexities in interfacing with the guts of GCC, would it 
make sense to expose the validate method?

> +/* or just use std::string? */
> +class string : public memento
Is there some reason not to use std::string?  I really like using 
standard components rather than rolling our own.



OK for the trunk.

jeff



More information about the Jit mailing list