libjava build failure with read-only source tree
Bryce McKinlay
bmckinlay@gmail.com
Thu Sep 29 09:32:00 GMT 2011
On Thu, Sep 29, 2011 at 9:18 AM, Jan Beulich <JBeulich@suse.com> wrote:
> --- a/libjava/classpath/tools/Makefile.am
> +++ b/libjava/classpath/tools/Makefile.am
> @@ -371,6 +371,7 @@ endif
> ## BEGIN GCJ LOCAL
> cp -pR $(srcdir)/asm .
> cp -pR $(srcdir)/classes .
> + find asm classes -type d -exec chmod u+w \{\} \;
> if [ -d asm/.svn ]; then \
> find asm classes -depth -type d -name .svn -exec rm -rf \{\} \;; \
> fi
This patch looks fine to me, though I wonder if there is any good
reason why "cp -p" was used in the first place?
In any case, I'd say you can go ahead and check this in under the
"obvious" rule.
Bryce
More information about the Java
mailing list