RFA: libjava seems to miss some files for win32

Dave Korn dave.korn.cygwin@googlemail.com
Sat Jul 18 17:09:00 GMT 2009


Kai Tietz wrote:

> 	* gnu/java/security/jce/prng/natVMSecureRandomWin32.cc: Implementation
> 	for native win32.
> 
> Tested for x86 and x64 mingw targets. Ok for apply?

+  for (a = 0; a < length; a++, count++)
+   *bytes++= (jbyte) rand ();

  Surely not, the standard C library rand() function is completely unsuitable
for security purposes.  It should use the win32 crypto api to get real
high-quality random data I think.

    cheers,
      DaveK



More information about the Java mailing list