PATCH: Parallel compilation of class files

Mark Mitchell mark@codesourcery.com
Sun May 12 13:42:00 GMT 2002



--On Wednesday, May 08, 2002 10:41:37 PM -0300 Alexandre Oliva 
<aoliva@redhat.com> wrote:

> On May  8, 2002, Mark Mitchell <mark@codesourcery.com> wrote:
>
>> !       temporary_file_name = xmalloc (strlen (class_file_name)
>> ! 				     + strlen (".tmp") + 1);
>> !       sprintf (temporary_file_name, "%s.tmp", class_file_name);
>
> Consider using `concat (class_file_name, ".tmp");'
>
>> !       if (rename (temporary_file_name, class_file_name) == -1)
>> ! 	fatal_io_error ("can't create %s", class_file_name);
>
> wouldn't it be appropriate to unlink the temporary file in this case?

Both good suggestions; I'll kick off tests now.

-- 
Mark Mitchell                mark@codesourcery.com
CodeSourcery, LLC            http://www.codesourcery.com



More information about the Java mailing list