WIN-28: fix POSIX file descriptor numbering assumptions

Bryce McKinlay bryce@waitaki.otago.ac.nz
Mon Feb 25 15:44:00 GMT 2002


Adam Megacz wrote:

>ok to commit?
>
>  - a
>
>2002-02-25  Adam Megacz  <adam@xwt.org>
>
>        * java/io/FileDescriptor.java: We now use getFD**().
>        * java/io/natFileDescriptorWin32.cc (getFDin, getFDout,
>        getFDerr): Added these.
>        * java/io/natFileDescriptorPosix.cc (getFDin, getFDout,
>        getFDerr): Added these.
>        * java/io/natFileDescriptorEcos.cc (getFDin, getFDout,
>        getFDerr): Added these.
>

Is a file descriptor on windows really an int, or is it a pointer? If 
its the latter, I don't think we should cast it to an int because it 
will break on 64-bit.

I recall seeing a patch from Jeff a long time ago to fix FileDescriptor 
to be more portable and not make the POSIX file-descriptor-is-an-int 
assumption, but it never got checked in.

regards

Bryce.





More information about the Java mailing list