GC failure w/ THREAD_LOCAL_ALLOC ?

Michael Smith msmith@spinnakernet.com
Mon Apr 1 08:14:00 GMT 2002


Boehm, Hans wrote:
 > I have seen no more failures with the patch, so far.  And I did
 > finally reproduce them without it.  It would be interesting if
 > particularly Jeff and Michael could confirm that.  (Michael - you
 > already had some of the other changes, so this probably won't apply
 > cleanly without backing those out.)

I managed to manually merge them in, except:

 > Index: linux_threads.c
 > ===================================================================
 > RCS file: /cvs/gcc/gcc/boehm-gc/linux_threads.c,v
 > retrieving revision 1.18.2.1
 > diff -u -r1.18.2.1 linux_threads.c
 > --- linux_threads.c	2002/03/25 18:23:36	1.18.2.1
 > +++ linux_threads.c	2002/03/29 02:15:18
[snip]
 > @@ -544,7 +546,7 @@
 >  	  ABORT("pthread_attr_getstacksize failed\n");
 >  	if (old_size < MIN_STACK_SIZE) {
 >  	  if (pthread_attr_setstacksize(&attr, MIN_STACK_SIZE) != 0)
 > -	    ABORT("pthread_attr_getstacksize failed\n");
 > +		  ABORT("pthread_attr_setstacksize failed\n");
 >  	}
 >        }
 >  #   endif /* HPUX */

this hunk didn't apply -- the code doesn't seem to even exist in my
version.  Doesn't appear to matter though: a) the change does not appear
to be substantial, and b) HPUX isn't defined, so it probably wouldn't
have touched this anyway.  :)

With the rest of the changes applied, I can no longer replicate the 
problem using GCTest.

Thanks Hans!

Do you recommend running without GC_IGNORE_GCJ_INFO now that this fix is in?

regards,
michael



More information about the Java mailing list