libgcj/38

Tom Tromey tromey@cygnus.com
Fri Feb 25 01:00:00 GMT 2000


The following reply was made to PR libgcj/38; it has been noted by GNATS.

From: Tom Tromey <tromey@cygnus.com>
To: Bryce McKinlay <bryce@albatross.co.nz>
Cc: tromey@cygnus.com, java-gnats@sourceware.cygnus.com,
        Java Patch List <java-patches@sourceware.cygnus.com>
Subject: Re: libgcj/38
Date: Fri, 25 Feb 2000 00:55:55 -0800 (PST)

 Bryce>  Well now that you point this out, it will have to synchronize
 Bryce>  around the "locale == null" check in getHeaderDateField()
 Bryce>  too. Bummer.
 
 Actually, you don't.  Just have redundant checks.  The outer check (in
 getHeaderDateField) doesn't have to be synchronized, because we do a
 properly synchronized in the init function.
 
 We use this same idiom elsewhere in libgcj.  This gives good
 performance in the common case (no sync needed), but is also
 guaranteed to be correct.
 
 Tom
 


More information about the Java-prs mailing list