[RFC] interpreter use of closures and return types

Matthew Fortune Matthew.Fortune@imgtec.com
Wed Jun 22 12:53:00 GMT 2016


Anthony Green <green@redhat.com> writes:
> Matthew Fortune <Matthew.Fortune@imgtec.com> writes:
> 
> > The root of the problem seems to be in a oddity of FFI that integer return
> > values less than word (or rather register) size are returned as an
> > ffi_arg.
> 
> Yes, this is expected behaviour.
> 
> > The java interpreter does not appear to adhere to this and the patch below
> > seems to fix the issue. Can anyone comment if this looks like the right
> > approach?
> 
> On the surface it looks good to me.

Thanks, I'll get on with testing then. As you can see I was somewhat unsure
of the fix, I initially had patched libffi for MIPS n32 until I realised
the ffi_arg quirk. It seems a few projects have fallen foul of this with
32-bit integers and 64-bit architectures. Libguile had the same issue some
time ago.

Matthew



More information about the Java-patches mailing list