avoid useless if-before-free tests

Dr Andrew John Hughes ahughes@redhat.com
Tue Mar 8 16:57:00 GMT 2011


On 22:47 Mon 07 Mar     , Joseph S. Myers wrote:
> On Mon, 7 Mar 2011, Dr Andrew John Hughes wrote:
> 
> > > http://gcc.gnu.org/codingconventions.html says Classpath changes should go 
> > > via Classpath upstream, not directly into GCC.  I don't know if that's 
> > > still accurate.
> > > 
> > 
> > That's still true.  This seems to be the first message I've received in this
> > thread, so I'm not even aware of what these changes are.  Were the earlier
> > messages not sent to this list?
> 
> The original patch went only to gcc-patches.
> 
> http://gcc.gnu.org/ml/gcc-patches/2011-03/msg00252.html
> 

Thanks for the link.

I'd like some explanation of why these changes are necessary before we start
adding them to Classpath.  Are we just assuming that all free implementations
will ignore NULL now?

With regards to fdlibm, there is a further upstream for this where
these changes should be made first.  fdlibm is also used by OpenJDK.

> -- 
> Joseph S. Myers
> joseph@codesourcery.com

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37



More information about the Java-patches mailing list