[PATCH v2] Re: avoid useless if-before-free tests

Ian Lance Taylor iant@google.com
Tue Mar 8 15:28:00 GMT 2011


Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:

>> I found no ChangeLog for libgo and no other libgo-related entries.
>> I suspect that means I should omit this change because it belongs upstream.
>
> Indeed, cf. libgo/README*.  I've Cc'ed Ian who maintains this part of
> GCC.

Yes, libgo is upstream but in any case I'd prefer that you not make the
change to libgo/runtime/go-select.c.  I'm aware that free (NULL) is a
no-op but I wrote the code that way because it is extremely unlikely
that allocated_buffer != NULL.  I am simply inlining the common case.
Thanks.

Ian



More information about the Java-patches mailing list