[testsuite, build] Convert boehm-gc testsuite to DejaGnu (PR boehm-gc/11412)

Ralf Wildenhues Ralf.Wildenhues@gmx.de
Tue Jan 18 20:21:00 GMT 2011


* Rainer Orth wrote on Mon, Jan 17, 2011 at 01:11:45PM CET:
> I've now got a patch I'm reasonably happy with.  It incorporates all the
> review comments.  Tested on i386-pc-solaris2.10, i386-pc-solaris2.10 and
> sparc-sun-solaris2.11.
> 
> Since I'm performing a call to dg-test from within another dg-test
> invocation (dg-test -> dg-add-shlib -> dg-test), I have to work around
> the fact that this doesn't work in DejaGnu 1.4.4.  I'll submit a DejaGnu
> patch shortly, but ${tool}-build-shlib works without and with this patch.
> 
> The patch below omits all but two of the renamed files (the exceptions
> being trace_test.c, which aquired a dg-skip-if, and staticsroottest.c,
> which got a dg-add-shlib).
> 
> Ok for mainline (either now, or, more likely, after 4.6 branches?

I'm not the right person to decide this; the build system specific
parts look ok to me.  In site.exp, you set srcdir to $(srcdir) and not
an absolute value; there's an Automake bug open about this issue
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7833 pending feedback from
http://thread.gmane.org/gmane.comp.sysutils.dejagnu.bugs/345
and since there is precedent also for using $(srcdir) (in v3 and
libjava), I guess that is ok too.

Cheers, and thanks,
Ralf

> 2010-12-31  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
> 
> 	PR boehm-gc/11412
> 	* Makefile.am (AUTOMAKE_OPTIONS): Use foreign instead of cygnus.
> 	(SUBDIRS): Add testsuite.
> 	(libgcjgc_la_LIBADD): Remove $(UNWINDLIBS).
> 	Remove TESTS related variables.
> 	(AM_MAKEFLAGS): Don't pass RUNTEST.
> 	* configure.ac: Add testsuite/Makefile to AC_CONFIG_FILES.
> 	* Makefile.in: Regenerate.
> 	* configure: Regenerate.
> 	* testsuite/Makefile.am: New file.
> 	* testsuite/Makefile.in: New file.
> 	* testsuite/lib/boehm-gc.exp: New file.
> 	* testsuite/config/default.exp: New file.
> 	* testsuite/boehm-gc.c/c.exp: New file.
> 	* testsuite/boehm-gc.lib/lib.exp: New file.
> 	* tests/test.c: Move ...
> 	* testsuite/boehm-gc.c/gctest.c: ... here.
> 	* tests/leak_test.c, tests/middle.c, tests/thread_leak_test.c,
> 	tests/trace_test.c: Move ...
> 	* testsuite/boehm-gc.c: ... here.
> 	* testsuite/boehm-gc.c/trace_test.c: Skip everywhere.
> 	* tests/staticrootslib.c, tests/staticrootstest.c: Move ...
> 	* testsuite/boehm-gc.lib: ... here.
> 	* testsuite/boehm-gc.lib/staticrootstest.c: Use dg-add-shlib
> 	staticrootslib.c.
> 	* tests/test_cpp.cc: Move ...
> 	* testsuite/boehm-gc.c++: ... here.



More information about the Java-patches mailing list