gcc-4.3.0-RC-20080301 test failures on ARM EABI

Andrew Haley aph@redhat.com
Mon Mar 3 17:05:00 GMT 2008


This is a testsuite bug that I'd like to fix on gcc 4.3 branch.  It means
that all gcj tests fail on ARM EABI.

TCL's string match command doesn't have the semantics that the patch author
thought it had, and so a vital piece of logic isn't being executed in the
testsuite.  string match has glob semantics rather than regexp semantics,
and this is needlessly obscure.  Fixed thusly.

Andrew.



2008-03-03  Andrew Haley  <aph@littlepinkcloud.com>

	* testsuite/lib/libjava.exp (libjava_arguments): Use regexp
	instead of string match when checking for linux targets.
 
Index: testsuite/lib/libjava.exp
===================================================================
--- testsuite/lib/libjava.exp	(revision 131034)
+++ testsuite/lib/libjava.exp	(working copy)
@@ -380,7 +380,7 @@
 	global wrapper_file wrap_compile_flags
 	lappend args "additional_flags=$wrap_compile_flags"
 
-	if { [string match "linux" $target_triplet] } {
+	if { [regexp "linux" $target_triplet] } {
 	    lappend args "additional_flags=-specs=libgcj-test.spec"
 	}
 



More information about the Java-patches mailing list