[Patch] libffi testsuite: Correct some type specifiers.
David Daney
ddaney@avtrex.com
Tue Aug 7 17:18:00 GMT 2007
Tom Tromey wrote:
>>>>>> "David" == David Daney <ddaney@avtrex.com> writes:
>
> David> Whilst hacking things up to get MIPS64 working better in libffi, I
> David> came across several test cases where structure elements were declared
> David> as type 'int' but the libffi type specifier identified them as uint32.
>
> David> This patch corrects some (but probably not all) of these incongruities.
>
> I think a patch to fix a disparity like this would qualify as obvious.
>
> However... if the struct definition says 'int', and the test case is
> says ffi_type_sint32, then that seems like a bug in itself. There's
> no guarantee that int == 32 bits. Wouldn't it be more correct to use
> ffi_type_sint?
I thought of that after I sent the patch, and I agree. The problem is
pervasive in the testsuite. Patch withdrawn.
I will submit a revised patch soon.
David Daney
More information about the Java-patches
mailing list