[Patch] libffi testsuite: Correct some type specifiers.

Tom Tromey tromey@redhat.com
Tue Aug 7 17:04:00 GMT 2007


>>>>> "David" == David Daney <ddaney@avtrex.com> writes:

David> Whilst hacking things up to get MIPS64 working better in libffi, I
David> came across several test cases where structure elements were declared
David> as type 'int' but the libffi type specifier identified them as uint32.

David> This patch corrects some (but probably not all) of these incongruities.

I think a patch to fix a disparity like this would qualify as obvious.

However... if the struct definition says 'int', and the test case is
says ffi_type_sint32, then that seems like a bug in itself.  There's
no guarantee that int == 32 bits.  Wouldn't it be more correct to use
ffi_type_sint?

Tom



More information about the Java-patches mailing list