[patch ping] libffi/boehm-gc/crt files executable stack (missing .note.GNU-stack on .o files)

[Andrew Haley]

Jakub Jelinek writes:
 > On Thu, Jul 05, 2007 at 12:51:51PM +0200, Matthias Klose wrote:
 > > The following patch (taken from the redhat/gcc-4_1-branch) adds .note.GNU-stack
 > > sections for gcc's crt files, libffi and boehm-gc.
 > > 
 > > sent first here: http://gcc.gnu.org/ml/gcc-patches/2006-12/msg00948.html
 > > 
 > > Updated in the patch is:
 > > 
 > > 2007-05-11  Daniel Jacobowitz  <dan@debian.org>
 > > 
 > >         * src/arm/sysv.S: Fix ARM comment marker.
 > > 
 > > Jakub, is this patch necessary/wanted in the FSF sources?
 > 
 > Yes, except perhaps the ppc64 and ia64 bits.  There it is ambiguous whether
 > PT_GNU_STACK segments are desirable or not (varries between upstream and
 > distros) and recent changes in binutils on ia64 and ppc64 assume by
 > default non-executable stack whe .note.GNU-stack section is not present,
 > so explicit .note.GNU-stack with "x" needs to be used to force
 > executable PT_GNU_STACK.

But why?  libffi doesn't need an executable stack, and libgcj
definitely doesn't want it.

Andrew.