[RFA] Add NormalBreakpoint

Tom Tromey tromey@redhat.com
Thu Jun 14 02:40:00 GMT 2007


>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> Right, the other new breakpoint type, ExecuteMethodBreakpoint will
Keith> also set this. interpret-run.cc will then use Breakpoint.type() to
Keith> figure out how to handle the breakpoint. Call me old fashioned, but I
Keith> really dislike using instanceof. O:-)

Classic OO would be to put a method on the Breakpoint so the different
types know how to handle themselves :-)

Adding a type field just to avoid instanceof doesn't seem so great,
unless there's a particular reason.  But if you really want to do it,
it seems to me that the allowable values should be defined in the base
class.

Tom



More information about the Java-patches mailing list