[RFA] Step & Breakpoint co-located events
Keith Seitz
keiths@redhat.com
Tue May 8 01:11:00 GMT 2007
Hi,
The attached patch "fixes" the multiple co-located events problems at a
location. [Review: we currently require two steps while stepping through
a line with a breakpoint: one for the step and one for the breakpoint.]
According to the JDWP specification, we can expect to receive
MethodEntry (or MethodExit), Step, and Breakpoint events together in a
single packet. While I have not implemented MethodEntry/Exit (since: 1)
we don't have them and 2) they don't seem all that useful for JDWP), I
have left them out of the equation. However, the same framework could be
used to deal with MethodEntry/Exit if they were added.
QCC?
Keith
ChangeLog
2007-05-07 Keith Seitz <keiths@redhat.com>
* include/java-interp.h (breakpoint_at): Declare.
* interpret.cc (breakpoint_at): New function.
* gnu/classpath/jdwp/VMVirtualMachine.java (_event_list):
New member.
* gnu/classpath/jdwp/natVMVirtualMachine.cc (initialize):
Initialize _event_list.
(handle_single_step): If there is a breakpoint at the
location at which we are stopping, do not send the notification.
Instead add the event to a list of events that occur at this
location.
(jdwpBreakpointCB): If the event list is not empty, send
whatever events are in it and the breakpoint event in a single
notification.
Mark parameter jni_env as MAYBE_UNUSED.
* classpath/lib/gnu/classpath/jdwp/VMVirtualMachine.class:
Regenerated.
* gnu/classpath/jdwp/VMVirtualMachine.h: Regenerated.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: step-and-break.patch
Type: text/x-patch
Size: 3866 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/java-patches/attachments/20070508/69a8438b/attachment.bin>
More information about the Java-patches
mailing list