[RH 4.1] Patch: FYI: work around bug with eclipse

Tom Tromey tromey@redhat.com
Mon Apr 23 19:10:00 GMT 2007


I'm checking this in on the RH 4.1 branch.

For some reason Eclipse triggers our method argument type check.
See:
    http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236895

I think this must be invalid code somewhere in Eclipse, but that is
difficult to prove.  And, since time is short for the release of F7,
it is simpler to just disable this check.  This is ok since the check
itself is new, and we don't really lose much by disabling it.

Tom

Index: ChangeLog
from  Tom Tromey  <tromey@redhat.com>

	http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236895
	* link.cc (resolve_method_entry): Disable method argument type
	check.

Index: link.cc
===================================================================
--- link.cc	(revision 124069)
+++ link.cc	(working copy)
@@ -362,9 +362,12 @@
   // i.e., exactly the same jclass object. JVMS 5.4.3.3
   if (found_class->loader != klass->loader)
     {
+#if 0
       JArray<jclass> *found_args, *klass_args;
       jclass found_return, klass_return;
 
+      // We disable this check due to:
+      // http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236895
       _Jv_GetTypesFromSignature (the_method,
 				 found_class,
 				 &found_args,
@@ -386,6 +389,7 @@
       if (found_return != klass_return)
 	throw new java::lang::LinkageError (JvNewStringLatin1
 	  ("return type mismatch with different loaders"));
+#endif
     }
   
   return the_method;



More information about the Java-patches mailing list