Patch: PR libgcj/23758, Fix theoretical race PosixProcess.
Tom Tromey
tromey@redhat.com
Mon Apr 9 17:01:00 GMT 2007
>>>>> "David" == David Daney <ddaney@avtrex.com> writes:
David> This patch moves the mallocs out of the danger zone in
David> natPosixProcess.cc
David> OK to commit?
Two nits -- fix these and it is ok.
David> + // explicitly. We need three extra slots. Potentailly PATH
Typo, should be "potentially".
David> + if (0 == strncmp (env[i], "PATH=", sizeof("PATH=")))
David> + need_path = false;
David> + if (0 == strncmp (env[i], "LD_LIBRARY_PATH=",
David> + sizeof("LD_LIBRARY_PATH=")))
David> + need_ld_library_path = false;
Use "! strncmp" instead. That's libgcj convention.
thanks,
Tom
More information about the Java-patches
mailing list