[RFA] JVMTI Agent Loading

Tom Tromey tromey@redhat.com
Wed Apr 4 19:58:00 GMT 2007


>>>>> "Kyle" == Kyle Galloway <kgallowa@redhat.com> writes:

Kyle> I think I have all the changes made now, but I've attached a revised
Kyle> patch here in case there are any other issues before I check this in.

Just a couple little nits, please fix them & commit.
Thanks.

Kyle> +// If LTDL cannot be used, return an error code indicating this
Kyle> +return -99;

This is still not indented correctly.

Also, comments in libgcj are (or ought to be :-) full sentences
starting with a capital letter (unless there's a good reason why not)
and ending in a period.  Most of the comments being added need a
little tweak here.

Tom



More information about the Java-patches mailing list