[RFA] JDWP VMMethod::getVariableTable

Kyle Galloway kgallowa@redhat.com
Tue Mar 6 21:10:00 GMT 2007


Tom Tromey wrote:
>>>>>> "Kyle" == Kyle Galloway <kgallowa@redhat.com> writes:
>>>>>>             
>
> Kyle> The CHECK_INTERP_CLASS macro ensures that the class of the
> Kyle> method is interpreted.
>
> I think getLineTable should be updated to use the new macro.
>
> Kyle> +      String *msg = reinterpret_cast<String *> (JvNewStringUTF (error));
>
> I think you shouldn't need the cast here.
>
> Aside from these, this is ok.  Thanks.
I made those small changes and have committed this patch.

Thanks,
Kyle



More information about the Java-patches mailing list