Patch: RFC: fix ProcessBuilder; windows help needed

[Mohan Embar]

Hi Tom,

>I'm still testing this patch.  I'll check it in once I'm done.
>
>During the last Classpath merge I must have stubbed out
>ProcessBuilder.  This patch fixes that and removes a divergence of
>ours in the process.
>
>One problem with this patch is that I did not update the Windows
>port.  I added the needed method argument, but it does not do
>anything.  I would appreciate it if someone could fix this.

I've started to roll up my sleeves and look at this. The patch is
a tiny bit stale (my fault because I waited so long) because of
System.java, but I think I hand-applied the rejected hunks okay.
I'm new to the whole --enable-maintainer-mode thing. Reading
HACKING, it seems that after I've applied the patch, with automake
1.96 and autoconf 2.59 in my path, I need to do this:

./scripts/makemake.tcl > sources.am
automake

There are other steps, but I'm not sure if I have to follow them.
Two items from the document confused me, so I'm going to wait for further
advice before I proceed:

  "Possibly update the gcj/javaprims.h file with scripts/classes.pl
  (See below, it can only be done after the first source->bytecode
   pass has finished.)"

Does this need to be done? You've added a java.lang.VMProcess.

  "You will need to configure with --enable-maintainer-mode and you
  will need to update the .class files and generated CNI header files in
  your working tree"

I think what the above means is passing --enable-maintainer-mode as
a top-level configure flag, but I am stumped as to what "and you
will need to update the .class files and generated CNI header files in
your working tree" means.

To summarize, I'd like to know exactly what scripts to run after I apply
your patch (and ideally, why I'm running them).

I'd like to get up to speed on all of this, but if you're concerned about
time, a faster path might be committing your changes and letting me
pick of the pieces on the Win32 side. Your call.

-- Mohan
http://www.thisiscool.com/
http://www.animalsong.org/