[RFA] "Rewrite" GetFrameCount

Keith Seitz keiths@redhat.com
Thu Feb 8 01:55:00 GMT 2007


Tom Tromey wrote:

> Looks good to me, thanks.

Committed. Thanks.

> I think one of Kyle's recent patches had some code to compute the
> stack depth, but it did something special if the frame was not found.
> I didn't look to see if this is a candidate for reuse.

I think that was GetStackTrace, which differentiates between native 
frames and interpreted frames. It already uses GetFrameCount. It could 
use _Jv_Frame::depth, too, if we so wanted to change it. I've left it as 
is. Something symmetrical about JVMTI code calling JVMTI code to do 
tasks. If you want me to change it, just say the word.

Keith



More information about the Java-patches mailing list