[RFA] JVMTI Interpreted Tests
Kyle Galloway
kgallowa@redhat.com
Thu Jan 25 14:42:00 GMT 2007
Kyle Galloway wrote:
> Tom Tromey wrote:
>> Kyle> Comments, or can I commit this?
>>
>> Just one change.
>>
>> Kyle> +# Run the JVMTI tests.
>> Kyle> +proc gcj_jvmti_run {} {
>> [...]
>> Kyle> +
>> Kyle> +gcj_jvmti_run
>>
>> Name this gij_jvmti_run.
>> It is ok to redefine procs in Tcl, but it is a bit clearer if they
>> have unique names. (I see you did this elsewhere so I guess you just
>> missed this one :)
>>
>> This is ok with this change.
>>
> Changed and committed.
I just noticed a small thinko in this patch that might cause some
problems, so I am checking in a fix as trivial.
2007-01-25 Kyle Galloway <kgallowa@redhat.com>
* testsuite/libjava.jvmti/lib/libjava.exp (exec_gij): Change [ to { in
if statement.
Thanks,
Kyle
More information about the Java-patches
mailing list