[java/PATCH] PR 30454 Fix bootstrap on a couple of targets, empty "zip" file in class path can cause leakage of file streams

Andrew Pinski pinskia@gmail.com
Wed Jan 24 05:46:00 GMT 2007


On Tue, 2007-01-23 at 08:40 -0700, Tom Tromey wrote:
> >>>>> "Andrew" == Andrew Pinski <pinskia@gmail.com> writes:
> 
> Andrew> The problem here is that empty "zip" files in the classpath
> Andrew> would cause leakage of file streams which meant after a while,
> Andrew> we hit the limit of opened files.
> 
> Nice catch, thanks.
> 
> Andrew> OK?
> 
> I think we should free 'zipf' in the 'return NULL' cases.
> Ok with that change.

And this is what I applied.

Thanks,
Andrew Pinski

2007-01-23  Andrew Pinski  <pinskia@gmail.com>

	PR java/30454
	* jcf-io.c (opendir_in_zip): Close the file
	and free zipf before returning after an error.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: fixjava.diff.txt
Type: text/x-patch
Size: 1041 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/java-patches/attachments/20070124/9a5c14dd/attachment.bin>


More information about the Java-patches mailing list