Patch [ecj]: Fix cross-configury issues / compile ecj.jar for non-shared builds

Mohan Embar gnustuff@thisiscool.com
Thu Dec 7 16:04:00 GMT 2006


Hi Andrew,

>There are some very subtle details that are easy to miss: for example,
>a Thread.interrupt() followed by a park() does not block the thread
>because Thread.interrupt() always does an unpark().  This means that
>there is no race between Thread.interrupt() and park(); it doesn't
>matter in which order they occur.  I think your proposed change might
>have broken that.

You're right. I hadn't completely understood the concept of permits when
I wrote that patch. Rereading the JavaDoc for LockSupport, I see that I
can't eliminate the call to unpark() in Thread.interrupt().

-- Mohan
http://www.thisiscool.com/
http://www.animalsong.org/





More information about the Java-patches mailing list