[ecj] natVMStackWalker.cc comment fixes

Gary Benson gbenson@redhat.com
Tue Dec 5 14:55:00 GMT 2006


Hi again,

This commit removes a bunch of FIXME comments about security
checks in natVMStackWalker.cc.  Classes in gnu.classpath are
intended to be protected from user access by the security
manager and should not contain security checks.

Cheers,
Gary
-------------- next part --------------
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 119540)
+++ ChangeLog	(working copy)
@@ -1,3 +1,7 @@
+2006-12-05  Gary Benson  <gbenson@redhat.com>
+
+	* gnu/classpath/natVMStackWalker.cc: Comment fixes.
+
 2006-12-05  Gary Benson  <gbenson@redhat.com>
 
 	* gnu/classpath/natVMStackWalker.cc (getCallingClass): Unwind
Index: gnu/classpath/natVMStackWalker.cc
===================================================================
--- gnu/classpath/natVMStackWalker.cc	(revision 119540)
+++ gnu/classpath/natVMStackWalker.cc	(working copy)
@@ -21,15 +21,12 @@
 JArray<jclass> *
 gnu::classpath::VMStackWalker::getClassContext(void)
 {
-  // FIXME: Security check here?
   return _Jv_StackTrace::GetStackWalkerStack ();
 }
 
 jclass
 gnu::classpath::VMStackWalker::getCallingClass(::gnu::gcj::RawData *pc)
 {
-  // FIXME: Security check here?
-
   void *f = _Unwind_FindEnclosingFunction (pc);
 
   // FIXME: it might well be a good idea to cache pc values here in
@@ -58,14 +55,12 @@
 ::java::lang::ClassLoader *
 gnu::classpath::VMStackWalker::getClassLoader(::java::lang::Class *c)
 {
-  // FIXME: Security check here?
   return c->getClassLoaderInternal ();
 }
 
 ::java::lang::ClassLoader *
 gnu::classpath::VMStackWalker::getCallingClassLoader(::gnu::gcj::RawData *pc)
 {
-  // FIXME: Security check here?
   return getCallingClass (pc)->getClassLoaderInternal ();
 }
 


More information about the Java-patches mailing list