[RFA/JVMTI] Fix a couple of thinkos
Tom Tromey
tromey@redhat.com
Wed Oct 11 23:27:00 GMT 2006
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Keith> First, the JVMTI namespace I
Keith> introduced to jvmti-int.h for event processing must have all the
Keith> members declared extern (and subsequently defined in one place).
This part is ok.
Keith> Second, we cannot simply lock the environment list in
Keith> _Jv_JVMTI_PostEvent. It would prevent another event from posting an
Keith> event because the lock would still be held by the suspended thread.
Hmm, can't we now dispose a jvmti environment while an event is being
posted? Perhaps leading to something bad?
Keith> + /* Don't even think about locking the env list here. It will prevent
Keith> + any events from being posted if some thread suspended as a result
Keith> + of a previous event. */
We may have to defer manipulations of the env list until it is safe.
Tom
More information about the Java-patches
mailing list