[RFA] Insn handling methods for _Jv_InterpMethod

[Keith Seitz]

I apologize for the massive delay: I got really sidetracked with 
cleaning this up properly using JVMTI (which turned out to be /much/ 
less trivial than I ever imagined).

Tom Tromey wrote:
>>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
> 
> Keith> +pc_t
> Keith> +_Jv_InterpMethod::install_break (jlong index)
> Keith> +{
> Keith> +#ifdef DIRECT_THREADED
> Keith> +  static insn_slot breakpoint_insn = {0};
> Keith> +  printf ("_Jv_InterpMethod::install_break at index %ld\n", (long) index);

Ignore this for now. I will post a separate patch which actually adds 
the breakpoint insn and the install_breakpoint method. It should not 
have been included here anyway: it is important enough to warrant its 
own patch.

> Keith> +  code = reinterpret_cast<pc_t> (prepared);
> 
> Perhaps 'prepared' should simply be declared as pc_t?
> 
> I think in the past we didn't declare this in java-interp.h.  But now
> that we do, being type-correct seems nicer.

I believe I've already committed a patch to address this.

Attached is the new patch to get/set insns for _Jv_InterpMethod. This is 
necessary for subsequent patches for insn handling in breakpoint 
management code.

Keith

ChangeLog
2006-10-09  Keith Seitz  <keiths@redhat.com>

         * include/java-interp.h (_Jv_InterpMethod::get_insn): Declare.
         (_Jv_InterpMethod::set_insn): Declare.
         * interpret.cc (_Jv_InterpMethod::get_insn): New method.
         (_Jv_InterpMethod::get_insn): New method.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: interp-getset-insns.patch
Type: text/x-patch
Size: 1703 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/java-patches/attachments/20061010/f2f164b5/attachment.bin>