[RFA/JVMTI] Implement GetErrorName
Keith Seitz
keiths@redhat.com
Wed Sep 20 17:04:00 GMT 2006
Tom Tromey wrote:
> Keith> + *name_ptr = (char *) _Jv_Malloc (strlen (name) + 1);
> Keith> + if (*name_ptr == NULL)
> Keith> + return JVMTI_ERROR_OUT_OF_MEMORY;
>
> I think you want _Jv_MallocUnchecked here.
> Hmm, I think we have this problem elsewhere in jvmti.cc.
I'll take a peek at that when I've finished the tests for the event
handling stuff. It looks like we probably only want to use the unchecked
variety and return JVMTI_ERROR_OUT_OF_MEMORY when the malloc fails. I
don't see anyplace where we wouldn't do this. Do you?
> With that change this is ok, thanks.
Committed. Thanks.
Keith
More information about the Java-patches
mailing list