RFA: Changes to interpreter to avoid non-debugging slowdown

Kyle Galloway kgallowa@redhat.com
Wed Aug 2 14:27:00 GMT 2006


Tom Tromey wrote:
>>>>>> "Kyle" == Kyle Galloway <kgallowa@redhat.com> writes:
>>>>>>             
>
> Kyle> There are other reasons for this as well, in addition to what Keith 
> Kyle> said.  If we want the full suite of event notifications, we need to add 
> Kyle> code to check for them so it could mean a slew of conditional checks to 
> Kyle> see if we are debugging.  If we instead can just #ifdef this code into 
> Kyle> the debugging version, it will mean we don't have to do conditional 
> Kyle> checks in either case
>
> Sounds good.
>
> Kyle> Small oversight on my part, I've fixed it.  I had also forgot
> Kyle> about the change in ncode() in the changelog.  New changelog and
> Kyle> new patch attached.
>
> The patch wasn't there... the changelog entry looks good though.
>
> Kyle>    * /include/java-interp.h (_Jv_InterpMethod::run_debug): New method.
>
> One nit: we don't put a '/' before the file name.
>   
Woops.....I've attached the patch and changed the changelog:

2006-07-28  Kyle Galloway  <kgallowa@redhat.com>

  * include/java-interp.h (_Jv_InterpMethod::run_debug): New method.
  * interpret.cc: Added placeholder for debug variable type info to STORE*
  macros.
  (_Jv_InterpMethod::run_debug): New method.
  (_Jv_InterpMethod::run_sync_object_debug): New method.
  (_Jv_InterpMethod::run_sync_class_debug): New method.
  (_Jv_InterpMethod::run_normal_debug): New method.
  (_Jv_InterpMethod::run_class_debug): New method.
  (_Jv_InterpMethod::ncode ()): Changed to select either debug or normal
  versions of these functions.
  * interpret-run.cc: New file, holds contents of old _Jv_InterpMethod::run
  method.
  * stacktrace.cc (_Jv_StackTrace::UnwindTraceFn): Changed to select
  appropriate function for debug or normal mode.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.diff
Type: text/x-patch
Size: 120222 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/java-patches/attachments/20060802/8487c6a2/attachment.bin>


More information about the Java-patches mailing list