RFC: AccessController merge

Gary Benson gbenson@redhat.com
Fri Jul 28 15:04:00 GMT 2006


Gary Benson wrote:
> Andrew Haley wrote:
> > I'm a bit concerned about efficiency.  For one example: OK, we walk
> > the stack -- we have to do that -- but we create a string for every
> > method name , and the only purpose of doing so AFAICS is to compare
> > it with "doPrivileged".  We then throw away all of those strings we
> > so laboriously constructed...
> 
> I see what you mean.  Another thing is that if there is a doPrivileged
> there then a chunk of the generated stack trace will be ignored.  I
> guess Casey wanted the code he put in stacktrace.cc to be generic.

Ok, so I'm thinking along the lines of the attached patch to solve
these two problems.  I thought I'd throw it out to the list before
I sit down and write the native bits in case there's any obvious
inefficiences that would make it just as bad.  Does it look ok?

Cheers,
Gary



More information about the Java-patches mailing list