[RFA/JVMTI] SuspendThread and ResumeThread
Keith Seitz
keiths@redhat.com
Fri Jul 21 23:45:00 GMT 2006
Tom Tromey wrote:
> Looks good. One little nit...
Little nit? You're being quite charitable, I think. That's a huge omission.
>
> Keith> Index: posix-threads.cc
> Keith> -void
> Keith> -_Jv_ThreadDebugSuspend (_Jv_Thread_t *data)
> Keith> -{
> Keith> -}
>
> It seems to me that these should also be removed from win32-threads.cc.
>
> Also there are declarations in include/*-threads.h, perhaps they
> should be moved elsewhere.
Yes, I've just grepped the daylights out of my tree, and I think this
covers all of them:
2006-07-21 Keith Seitz <keiths@redhat.com>
* boehm.cc (_Jv_SuspendThread): Don't ifdef the function
declaration,
just the contents.
(_Jv_ResumeThread): Likewise.
* posix-threads.cc: Revert 2006-06-19 _Jv_ThreadDebugSuspend,
_Jv_ThreadDebugResume, _Jv_ThreadDebugSuspendCount patch. Moving
to JVMTI instead.
* include/posix-threads.h: Likewise.
* win32-threads.cc: Likewise.
* include/win32-threads.h: Likewise.
* jvmti.cc (_Jv_JVMTI_SuspentThread): New function.
(_Jv_JVMTI_ResumeThread): New function.
(_Jv_JVMTI_Interface): Define SuspendThread and ResumeThread.
I've committed the original patch with the requisite _Jv_ThreadDebug*
expunging.
Thanks,
Keith
More information about the Java-patches
mailing list